Comments on: Horde/Routes 0.4 Released http://mikenaberezny.com/2009/03/04/horderoutes-04-released/ Fri, 01 Jul 2011 12:51:52 +0000 hourly 1 By: Mike Naberezny http://mikenaberezny.com/2009/03/04/horderoutes-04-released/comment-page-1/#comment-137928 Mike Naberezny Thu, 05 Mar 2009 04:29:33 +0000 http://mikenaberezny.com/?p=888#comment-137928 Josh, You can submit bug reports or patches on <a href="http://bugs.horde.org" rel="nofollow">bugs.horde.org</a>. Please select the "Horde Framework Packages" queue. Thanks for reporting the issue with unset(). It has been fixed on Git master. Regards, Mike Josh,

You can submit bug reports or patches on bugs.horde.org. Please select the “Horde Framework Packages” queue.

Thanks for reporting the issue with unset(). It has been fixed on Git master.

Regards,
Mike

]]> By: Josh Davis http://mikenaberezny.com/2009/03/04/horderoutes-04-released/comment-page-1/#comment-137924 Josh Davis Thu, 05 Mar 2009 02:51:30 +0000 http://mikenaberezny.com/?p=888#comment-137924 Horde/Routes really looks good so far, I hope it will see widespread adoption. I'm currently evaluating my own needs to see if I could benefit from using Horde/Routes rather than rolling my own router (I'm not even sure I need a router at this point) so I've downloaded Horde/Routes and I started poking around the source code to see how complex it was. I have noticed a couple of routines that could be simplified/streamlined, and a potential bug, where can we submit those? I have an obsessive-compulsive tendency to benchmark/optimize any code I see, do you plan on accepting patches? Wrt that potential bug, it's in Route.php line ~188-189. There's an isset($kargs['_absolute']) followed by unset($kargs['absolute']). One has an underscore, the other doesn't. Horde/Routes really looks good so far, I hope it will see widespread adoption.

I’m currently evaluating my own needs to see if I could benefit from using Horde/Routes rather than rolling my own router (I’m not even sure I need a router at this point) so I’ve downloaded Horde/Routes and I started poking around the source code to see how complex it was. I have noticed a couple of routines that could be simplified/streamlined, and a potential bug, where can we submit those? I have an obsessive-compulsive tendency to benchmark/optimize any code I see, do you plan on accepting patches?

Wrt that potential bug, it’s in Route.php line ~188-189. There’s an isset($kargs['_absolute']) followed by unset($kargs['absolute']). One has an underscore, the other doesn’t.

]]>